Expose api to externally trigger trimming #2599
Conversation
|
CI gfxreconstruct build queued with queue ID 621373. |
|
CI gfxreconstruct build # 8566 running. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
9b2861c to
261b4af
Compare
|
CI gfxreconstruct build queued with queue ID 621403. |
|
CI gfxreconstruct build # 8567 running. |
|
CI gfxreconstruct build # 8567 passed. |
|
I set trimming signal callbacks with SetSignalTrimmingCallbacks(). For a frame range capture, I get the expected results. The callbacks happen at the expected frame. For a manual capture, where we set debug.gfxrecon.capture_android_trigger to true to start the capture and to false when we want to stop capturing, I seem to get the start signal at the expected frame, but the end signal comes back at the very next frame, even if I capture 100 frames. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
261b4af to
b8d602f
Compare
|
CI gfxreconstruct build queued with queue ID 623762. |
|
CI gfxreconstruct build # 8607 running. |
|
CI gfxreconstruct build # 8607 passed. |
This works as expected now |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
b8d602f to
180d86f
Compare
|
CI gfxreconstruct build queued with queue ID 626151. |
|
CI gfxreconstruct build # 8628 running. |
|
CI gfxreconstruct build # 8628 passed. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
180d86f to
50b6a6e
Compare
|
CI gfxreconstruct build queued with queue ID 626683. |
|
CI gfxreconstruct build # 8632 running. |
|
CI gfxreconstruct build # 8632 passed. |
|
CI gfxreconstruct build queued with queue ID 628172. |
|
CI gfxreconstruct build # 8652 running. |
|
CI gfxreconstruct build # 8652 failed. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
480e30e to
8bbf090
Compare
|
CI gfxreconstruct build queued with queue ID 628478. |
|
CI gfxreconstruct build # 8657 running. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
8bbf090 to
211a0f4
Compare
|
CI gfxreconstruct build queued with queue ID 628501. |
|
CI gfxreconstruct build # 8658 running. |
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
211a0f4 to
bd88947
Compare
|
CI gfxreconstruct build queued with queue ID 628521. |
|
CI gfxreconstruct build # 8659 running. |
panos-lunarg
requested review from
antonio-lunarg,
beau-lunarg and
bradgrantham-lunarg
|
CI gfxreconstruct build # 8659 passed. |
Two new functions are implemented and should be discoverable through dlopen+dlsym: * GFXRSetTrimmingState(bool): Controls enabling/disabling trimming. For this to work trimming must be enabled either by setting a hot key (desktop) or by enabling the android capture trigger option (debug.gfxrecon.capture_android_trigger) * GFXRGetCaptureMode() Returns the current capture mode GFXR as an uint32_t: - 0 (disabled): GFXR is disabled - 1 (write): Writing mode. This state means that GFXR is in full capture mode (not trimming) - 2 (track): GFXR is in tracking mode. Trimming can be enabled by either pressing the hot key (or setting the android trigger option) or by calling GFXRSetTrimmingState(true) - 3 (write and track): GFXR is writing a trimmed capture. Capturing can be interrupted by either pressing again the hot key (or setting the android trigger option appropriately) or by calling GFXRSetTrimmingState(false)
SetSignalTrimmingCallbacks should be possible to be discovered via dlopen+dlsym on the layer .so. This allows installing 2 callback functions which will be called when trimming state changes. First callback is called when trimming starts and the second when trimming stops
panos-lunarg
force-pushed
the
externally_trigger_trimming
branch
from
bd88947 to
a748cb0
Compare
|
CI gfxreconstruct build queued with queue ID 629028. |
|
@fabian-lunarg can you give this a lookover? |
4 participants
Two new functions are implemented and should be discoverable through dlopen+dlsym:
GFXRSetTrimmingState(bool): Controls enabling/disabling trimming. For this to work trimming must be enabled either by setting a hot key (desktop) or by enabling the android capture trigger option (debug.gfxrecon.capture_android_trigger)
GFXRGetCaptureMode() Returns the current capture mode GFXR as an uint32_t:
0 (disabled): GFXR is disabled
1 (write): Writing mode. This state means that GFXR is in full capture mode (not trimming)
2 (track): GFXR is in tracking mode. Trimming can be enabled by either pressing the hot key (or setting the android trigger option) or by calling GFXRSetTrimmingState(true)
3 (write and track): GFXR is writing a trimmed capture. Capturing can be interrupted by either pressing again the hot key (or setting the android trigger option appropriately) or by calling GFXRSetTrimmingState(false)